Looking at a possible bug

[drmike]

Greets:

You'll have to forgive me.  It's under 4 yell as loud as you can day here at the library and tracing code isn't in my mind set right now.

I'm looking at the function wpmu_validate_blog_signup in the wp-includes/wpmu-functions.php file.  I'm starting at line 1035 there:

http://trac.mu.wordpress.org/browser/trunk/wp-includes/wpmu-functions.php

1035 is a check to see if the blog exists.

1038 is a check to see if a username has or has not a blog attached to it.  If not (ie, it;s a username only account) assume that someday the user may claim their blog and kick out an error for everybody else.

1044 is what I'm really looking at.  It's a check to see if a visitor has created an account and, if it's not be verified within the last 48 hours, remove it from the signup log and release it for use else kick out with an error saying that it;s reserved.

What I'm not seeing though is a check for a username only account that's been registered within the last 48 hours, remove it from the signup log if it is present and it has been 48 hours, else kick out with an error.

Make sense or do I have to go tell little Timmy that he isn't god's gift to the ear doctor?

[ron_r]

Yep, that sounds like the way it works

[drmike]

As in "yes, it's an issue" or "I'm missing it"?

[Luke]

Beats me. I'm in South Padre.

[ron_r]

If it's less than 48 hours, the username is blocked from the signup page. That's the way it's worked since 1.2 if not before.

[drmike]

What I'm looking at though, if I understand the code correctly, is the check isn't being made if it's a username-only account.

[Luke]

Sunshine...   mmm mmm  good.

[Andrea_R]

*looks outside*

*looks back at picture*

I hate you.


 

[Luke]

It's a chilly 27C this afternoon.

It makes me ill to think it'll be back to freezing cold tomorrow afternoon.

[ron_r]

It is supposed to get above freezing here tomorrow. 

[Luke]

It's about 40 here today, and then back below freezing til the weekend.

Yep, back to the freezer for Luke, and it sucks.

[ron_r]

That's the weather we are getting now. 40's during the day, below freezing at night.

[Luke]

We've been 60's/70's for the past couple of weeks, with a couple of 80/81 days thrown in.

Of course I say this as a front went through, and has knocked that down to 40's/50's during the day, with mid-30's at night.

And gee, 60% chance of snow Saturday.

Although the ground is warm enough that it isn't going to stick.